Repository navigation
refactor: move *-experiments features out of the published crates into benchmarks/experiments - #277
Conversation
…longer_enables_feature)
…marks; map the ReadyGate Loom harness to benchmarks/experiments
🤖 Codex Code Review
I found no correctness or concurrency regression in the production actor-path removals. Automated review by OpenAI Codex · gpt-6.1-sol · custom prompt |
🤖 Claude Code ReviewReview: PR #277, move backend/IO/profiling experiments out of the published cratesThe direction is right. Taking the scheduler hooks off the actor hot path simplifies Two scripts are broken in a prepared tree. There is also a bit-rot risk worth addressing before merge. Bugs1.
2.
Risks / suggestions3. Nothing builds the experiments crate in CI, so it will rot silently
4. No lockfile for the experiments crate (
5.
6. Semver note for the CHANGELOG
7. Unverified compile of moved tests
Nits
Overall this is a good cleanup. Fix (1) and (2) before merge, and I'd strongly recommend (3) and (4) so the moved experiments stay runnable. Automated review by Claude · claude-opus-5-5 · custom prompt |
🤖 Gemini Code ReviewThe separation of the experimental backends/dependencies out of Two issues in the benchmark driver workflow when running from a tree prepared by
Automated review by Gemini · gemini-4-argon · custom prompt |
🤖 Grok Code ReviewThe published hot path cleanup is right: experiment branches are gone from dispatch, spawn, and Experiments crate will not build as written
Path deps on Also missing from that manifest: whatever the moved
|
🤖 Kimi Code ReviewAutomated review by Kimi (Moonshot AI) |
🤖 DeepSeek Code ReviewOverall this is a well-scoped cleanup: the published crates lose the heavy optional dependencies, the no-op feature names preserve patch-compatibility, and moving the experiment code into a patch-applied scratch tree keeps it out of the default build path. A few issues to consider: 1. Experiments crate defaults to Linux-only dependencies on all platforms
A plain 2. Moved tests lose root CI coverage unless the prepared-tree workflow is wired inThe new crate declares 3.
|
Post-0.8 cleanup: the
*-experimentsfeatures leave the published crates and move tobenchmarks/experiments/, kept runnable rather than deleted ("we might do it again").What moved where
benchmarks/experiments/(spawned-experiments,publish = false, its own[workspace], so monoio/pprof stay out of the root lockfile,cargo denyandcargo audit):designs,io_designs,workload_research,lifecycle_soak,pinned_pipeline,runtime_isolationand their support files (fromconcurrency/benches/);backend_experiments,full_actor_shards,native_dispatcher,ready_gate_loom,benchmark_startup(fromconcurrency/tests/), plus the two descriptor-limit tests split out ofbackend_resource_limits.rs(nowdescriptor_limit.rs);backend-experiments,io-experiments(monoio),profiling-experiments(pprof), same names so the sources moved unchanged.backend-experiments.patch+prepare.sh: the scheduler hooks sit on the actor hot path (spawn routing viaSPAWNED_EXPERIMENT_SCHEDULER,MessageTurnbatching/time slicing in the dispatch loop,SPAWNED_EXPERIMENT_RUNTIMEinthreads::block_on) plusrt/src/tasks/experimental*anddispatch_gate.rs. They can't live in a published crate, even behind a feature, so they're kept as a patch.prepare.shadds a scratch worktree and applies it. Applied to this branch, the patch reproducesmain'srt/srcandconcurrency/srcbyte for byte. The Python drivers now build with--manifest-path benchmarks/experiments/Cargo.tomlfrom a prepared tree.spawned-rtlosesasync-taskandcrossbeam-deque.spawned-concurrencylosesmonoio,pprofand everycfg(feature = "backend-experiments")branch. The three feature names stay as empty no-ops, becauseapi-compatibility(cargo-semver-checksfeature_missing) treats removing a feature as a major break under the 0.8 patch policy. Drop them at 0.9. The only change to default-build code is folding onelet result = …; result(left behind when the cfg'd turn hook was removed) into a tail expression (clippylet_and_return), which compiles to the same code.deny.toml/.cargo/audit.toml: the quick-xml, fxhash and CDDL (inferno) exceptions are gone with their deps, and so are the now-unused0BSDandBSD-2-Clauseallowances.benchmarks/README.md(new "Experiments" section),docs/TESTING.md,docs/GUIDE.md,ROADMAP.md, the research notes andCHANGELOG.md.Checks run locally
cargo clippy --workspace --all-targets [--all-features] -D warnings,cargo test -p spawned-concurrency --lib(243 passed),cargo deny --all-features check,cargo fmt --check. In a prepared tree: clippy on the experiments crate (all targets), thebenchmark_startup/backend_experimentstests and theturn_regressionsunit tests.Model: no change because this only deletes code compiled under the removed
backend-experimentsfeature; default and every remaining feature build of the modelled lifecycle code is unchanged.